Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ImageJ 1.54h breaks CellImgToVirtualStackTest #39

Closed
ctrueden opened this issue Feb 28, 2024 · 3 comments
Closed

ImageJ 1.54h breaks CellImgToVirtualStackTest #39

ctrueden opened this issue Feb 28, 2024 · 3 comments

Comments

@ctrueden
Copy link
Member

ctrueden commented Feb 28, 2024 •
edited 

$ mvn clean test -Dij.version=1.54h
...
[ERROR] net.imglib2.img.display.imagej.CellImgToVirtualStackTest.testPersistence -- Time elapsed: 0.007 s <<< FAILURE!
java.lang.AssertionError: expected:<42.0> but was:<0.0>
	...
	at net.imglib2.img.display.imagej.CellImgToVirtualStackTest.testPersistence(CellImgToVirtualStackTest.java:162)
	...

Whereas -Dij.version=1.54g works.
@ctrueden
Copy link
Member Author

The offending commit is imagej/ImageJ@6f5f96f, specifically these new lines:

if (newStack.isVirtual()) // work around bug with virtual stacks that cache pixel data
    		ip = ip.duplicate();

@rasband
Copy link

rasband commented Feb 29, 2024 •
edited

This regression is fixed in the ImageJ 1.54i25 daily build. The commit is at imagej/ImageJ@7579e16. I moved the work around for the problem with VirtualStacks caching ImageProcessors to the test plugin at
https://wsr.imagej.net/plugins/Test_Virtual_Stack.java
that reproduces the problem.

@rasband rasband closed this as completed Feb 29, 2024
@ctrueden
Copy link
Member Author

ctrueden commented Mar 1, 2024

Thanks, @rasband!

ctrueden added a commit to scijava/pom-scijava that referenced this issue Mar 4, 2024
@ctrueden
Downgrade ij: 1.54h -> 1.54g
a2e4bc4 
We cannot update to 1.54h due to a potentially critical bug in
the handling of virtual stacks when combined with ImgLib2; see:

imglib/imglib2-ij#39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ctrueden @rasband